-
Notifications
You must be signed in to change notification settings - Fork 49
Euclid Probe for EVA #29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Euclid Probe for EVA
replace bad .stp
|
Added dock files for V-Core legacy and V-Core3 |
blalor
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution, @nionio6915! I'm not a maintainer of this repository, but I see this PR has been open for a while and would like to give my feedback as a user.
These are the object files, but it's not clear which ones to use. There are two dock options for the V-Core 3, plus EuclidProbeDock.stl. Euclid_EVA_MountV5_M2.5SelfTapping.stl appears twice; the files are not identical copies, but appear to be very similar. As a user I would also like to have access to STEP files, although it's not clear where those would live in this repository (maybe docs/probes/step/?).
docs/probes/stls/EuclidProbeDock.stldocs/probes/stls/Euclid_EVA_MountV3.stldocs/probes/stls/Euclid_EVA_MountV3M3ThruBolts.stldocs/probes/stls/Euclid_EVA_MountV5_M2.5SelfTapping.stldocs/probes/stls/Legacy V-Core/LegacyVCoreDock.stldocs/probes/stls/Legacy V-Core/LegacyVCoreMount.stldocs/probes/stls/V-Core3/Euclid_EVA_DockV3_3030.stldocs/probes/stls/V-Core3/Euclid_EVA_DockV5_3030.stldocs/probes/stls/V-Core3/Euclid_EVA_MountV5_M2.5SelfTapping.stl
There are some extraneous files in this PR that should be linked to the documentation or removed in accordance with the submission guidelines.
These are assets, not object files, but are not linked:
docs/probes/stls/Legacy V-Core/FrontViewVCoreLegacy.pngdocs/probes/stls/Legacy V-Core/SideSection.pngdocs/probes/stls/Legacy V-Core/topview.pngdocs/probes/stls/V-Core3/Euclid_Probe_Screen1.jpgdocs/probes/stls/V-Core3/Euclid_Probe_Screen2.jpgdocs/probes/stls/V-Core3/Euclid_Probe_Screen3.jpgdocs/probes/stls/V-Core3/Euclid_Probe_Screen4.jpgdocs/probes/stls/V-Core3/unknown-768x550.jpg
These files are not appropriate assets, such as images shown inline in the euclid_probe.md document:
docs/probes/assets/EuclidProbeDockV2.stldocs/probes/assets/Euclid_EVA_MountV3.stldocs/probes/assets/EuclidDockV2.stpdocs/probes/assets/Euclid_EVA_MountV3.stp
These files do not conform to the naming structure and are not linked from the documentation, and the PNGs are duplicates.
docs/probes/assets/assets.zipdocs/probes/assets/front-view.pngdocs/probes/assets/unknown.png
ed9a61d to
faad436
Compare
Euclid Probe for EVA
Before you submit your pull request, please make sure that the necessary files are present.
The main page for your part should be in
docs/[category]/[your_part_name].mdAny assets linked from that page should be in
docs/[category]/assetsThe STL(s) should be in
docs/[category]/stlsHere's a checklist of the sections you should be adding to your .md file.
Write the name of the part you want to contribute here.
Euclid Probe
If relevant, what EVA version is your part compatible with? (example: 2.0.0 or 2.1.0 - 2.2.0)
Write the name of any relevant EVA parts, if any. This could be parts that are replaced or parts that your new part attaches to.
Does your part need any hardware to function? If yes, what?
M5x20 screw & T-nut
Euclid Probe (see https://github.com/nionio6915/Euclid_Probe)
Wiring as nescessary
Describe your part, what problems does it solve, and how?
A magnetically coupled Z probe that is not affected by heat or magnetism.
If you used onshape, please provide the link here. Step files are also allowed in the assets directory.
Step files added to assets folder
How should people print this?
0.2mm or 0.3mm layer heights, min of 3 perimeters, recommend 20% infill
Who made this? Feel free to include relevant links/handles (github, thingiverse, discord handle, etc).
Dennis P. https://github.com/nionio6915