Skip to content

Conversation

@nionio6915
Copy link

Euclid Probe for EVA

Before you submit your pull request, please make sure that the necessary files are present.

The main page for your part should be in docs/[category]/[your_part_name].md
Any assets linked from that page should be in docs/[category]/assets
The STL(s) should be in docs/[category]/stls

Here's a checklist of the sections you should be adding to your .md file.

  • Part name

Write the name of the part you want to contribute here.
Euclid Probe

  • Compatible EVA version

If relevant, what EVA version is your part compatible with? (example: 2.0.0 or 2.1.0 - 2.2.0)

  • Related EVA parts

Write the name of any relevant EVA parts, if any. This could be parts that are replaced or parts that your new part attaches to.

  • Necessary Hardware BOM

Does your part need any hardware to function? If yes, what?
M5x20 screw & T-nut
Euclid Probe (see https://github.com/nionio6915/Euclid_Probe)
Wiring as nescessary

  • Description

Describe your part, what problems does it solve, and how?
A magnetically coupled Z probe that is not affected by heat or magnetism.

  • Onshape or STEP files

If you used onshape, please provide the link here. Step files are also allowed in the assets directory.
Step files added to assets folder

  • Print instructions

How should people print this?
0.2mm or 0.3mm layer heights, min of 3 perimeters, recommend 20% infill

  • Contributor

Who made this? Feel free to include relevant links/handles (github, thingiverse, discord handle, etc).
Dennis P. https://github.com/nionio6915

@nionio6915
Copy link
Author

Added dock files for V-Core legacy and V-Core3

Copy link

@blalor blalor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution, @nionio6915! I'm not a maintainer of this repository, but I see this PR has been open for a while and would like to give my feedback as a user.

These are the object files, but it's not clear which ones to use. There are two dock options for the V-Core 3, plus EuclidProbeDock.stl. Euclid_EVA_MountV5_M2.5SelfTapping.stl appears twice; the files are not identical copies, but appear to be very similar. As a user I would also like to have access to STEP files, although it's not clear where those would live in this repository (maybe docs/probes/step/?).

  • docs/probes/stls/EuclidProbeDock.stl
  • docs/probes/stls/Euclid_EVA_MountV3.stl
  • docs/probes/stls/Euclid_EVA_MountV3M3ThruBolts.stl
  • docs/probes/stls/Euclid_EVA_MountV5_M2.5SelfTapping.stl
  • docs/probes/stls/Legacy V-Core/LegacyVCoreDock.stl
  • docs/probes/stls/Legacy V-Core/LegacyVCoreMount.stl
  • docs/probes/stls/V-Core3/Euclid_EVA_DockV3_3030.stl
  • docs/probes/stls/V-Core3/Euclid_EVA_DockV5_3030.stl
  • docs/probes/stls/V-Core3/Euclid_EVA_MountV5_M2.5SelfTapping.stl

There are some extraneous files in this PR that should be linked to the documentation or removed in accordance with the submission guidelines.

These are assets, not object files, but are not linked:

  • docs/probes/stls/Legacy V-Core/FrontViewVCoreLegacy.png
  • docs/probes/stls/Legacy V-Core/SideSection.png
  • docs/probes/stls/Legacy V-Core/topview.png
  • docs/probes/stls/V-Core3/Euclid_Probe_Screen1.jpg
  • docs/probes/stls/V-Core3/Euclid_Probe_Screen2.jpg
  • docs/probes/stls/V-Core3/Euclid_Probe_Screen3.jpg
  • docs/probes/stls/V-Core3/Euclid_Probe_Screen4.jpg
  • docs/probes/stls/V-Core3/unknown-768x550.jpg

These files are not appropriate assets, such as images shown inline in the euclid_probe.md document:

  • docs/probes/assets/EuclidProbeDockV2.stl
  • docs/probes/assets/Euclid_EVA_MountV3.stl
  • docs/probes/assets/EuclidDockV2.stp
  • docs/probes/assets/Euclid_EVA_MountV3.stp

These files do not conform to the naming structure and are not linked from the documentation, and the PNGs are duplicates.

  • docs/probes/assets/assets.zip
  • docs/probes/assets/front-view.png
  • docs/probes/assets/unknown.png

@pkucmus pkucmus force-pushed the main branch 5 times, most recently from ed9a61d to faad436 Compare January 1, 2022 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants